On 2021/02/20 1:00, Shuah Khan wrote:
> On 2/19/21 8:53 AM, Greg Kroah-Hartman wrote:
>> What changed from v1? Why isn't that info below the --- line?
>>
>> Please do a v3 with that fixed up.
>>
>
> +1 on this.
v2 fixed the PTR_ERR() access which was reported in v1 as below.
On 2021/02/20 2:10, Julia Lawall wrote:
> From: kernel test robot <lkp@xxxxxxxxx>
>
> PTR_ERR should access the value just tested by IS_ERR
>
> Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
>
> CC: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Julia Lawall <julia.lawall@xxxxxxxx>
>
> Also please run the usbip test on your changes:
> tools/testing/selftests/drivers/usb/usbip/usbip_test.sh
Too much requirements for me to run that test. I'm not a user of your module.
Please run that test on v2 using your environment.
root@fuzz:~/usbip-utils# ~/usbip-utils/src/usbip list -l
- busid 3-1 (0e0f:0003)
VMware, Inc. : Virtual Mouse (0e0f:0003)
root@fuzz:~/usbip-utils# ~/usbip-utils/src/usbipd -D
root@fuzz:~/usbip-utils# pidof usbipd
11191
root@fuzz:~/usbip-utils# ~/usbip-utils/src/usbip list -l
- busid 3-1 (0e0f:0003)
VMware, Inc. : Virtual Mouse (0e0f:0003)
root@fuzz:~/usbip-utils# ~/usbip-utils/src/usbip list --remote 127.0.0.1
Exportable USB devices
======================
- 127.0.0.1
3-1: VMware, Inc. : Virtual Mouse (0e0f:0003)
: /sys/devices/pci0000:00/0000:00:15.0/0000:03:00.0/usb3/3-1
: (Defined at Interface level) (00/00/00)
root@fuzz:~/usbip-utils#
