On Fri, Jul 31, 2009 at 06:05:24PM -0700, Robin Callender wrote: > Hi all, > The included patch can be applied to the new usb gadget audio driver > introduced in patch-2.6.31-rc4. > It addresses a seg-fault in uncovered in g_audio.ko. > The fault occurs in the function u_audio.c::gaudio_open_end_dev() when > device /dev/snd/pcmC0D0c (FILE_PCM_CAPTURE) is not present. > > I suspect there may be similar problems with device /dev/snd/pcmC0D0p > (FILE_PCM_PLAYBACK) handling also. > I leave that for the developer(s), as I was unsure as to the side-effects of > not calling playback_default_hw_params() in the initialization phase. > > - Robin Callender - > > ====================================================== > > diff -r linux-2.6.30.4.orig/drivers/usb/gadget/u_audio.c > linux-2.6.30.4/drivers/usb/gadget/u_audio.c > 256c256,261 > < snd->filp = NULL; Hm, can you redo this patch based on the info in the file, Documentation/SubmittingPatches which shows the needed options to diff (-u is the key), as well as the need for a Signed-off-by: line in the body of the email so that it can be applied? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
