[PATCH] usb gadget audio driver seg-fault fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi all,
The included patch can be applied to the new usb gadget audio driver introduced in patch-2.6.31-rc4.
It addresses a seg-fault in uncovered in g_audio.ko.
The fault occurs in the function u_audio.c::gaudio_open_end_dev() when device /dev/snd/pcmC0D0c (FILE_PCM_CAPTURE) is not present.

I suspect there may be similar problems with device /dev/snd/pcmC0D0p (FILE_PCM_PLAYBACK) handling also. I leave that for the developer(s), as I was unsure as to the side-effects of not calling playback_default_hw_params() in the initialization phase.

- Robin Callender -

======================================================

diff -r linux-2.6.30.4.orig/drivers/usb/gadget/u_audio.c linux-2.6.30.4/drivers/usb/gadget/u_audio.c
256c256,261
<   snd->filp = NULL;
---
  snd->substream = NULL;
  snd->card = NULL;
 } else {
  pcm_file = snd->filp->private_data;
  snd->substream = pcm_file->substream;
  snd->card = card;
258,260d262
<  pcm_file = snd->filp->private_data;
<  snd->substream = pcm_file->substream;
<  snd->card = card;

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux