On Thu, Jan 28, 2021 at 03:29:31PM +0300, Mika Westerberg wrote: > /** > - * tb_drom_read - copy drom to sw->drom and parse it > + * tb_drom_read() - Copy DROM to sw->drom and parse it > + * @sw: Router whose DROM to read and parse > + * > + * This function reads router DROM and if successful parses the entries and > + * populates the fields in @sw accordingly. Can be called for any router > + * generation. > + * > + * Returns %0 in case of success and negative errno otherwise. > */ > int tb_drom_read(struct tb_switch *sw) > { I'm confused by the terminology change of "router" vs. "switch". Is this change mandated by USB4? The parameter is a tb_switch, so calling it a router looks a little odd. Thanks, Lukas