gregkh@xxxxxxxxxxxxxxxxxxx wrote:
> On Fri, Jan 08, 2021 at 02:19:30AM +0000, Thinh Nguyen wrote:
>> Hi Wesley,
>>
>> Felipe Balbi wrote:
>>> Hi,
>>>
>>> Wesley Cheng <wcheng@xxxxxxxxxxxxxx> writes:
>>>> +void composite_reset(struct usb_gadget *gadget)
>>>> +{
>>>> + /*
>>>> + * Section 1.4.13 Standard Downstream Port of the USB battery charging
>>>> + * specification v1.2 states that a device connected on a SDP shall only
>>>> + * draw at max 100mA while in a connected, but unconfigured state.
>>> The requirements are different, though. I think OTG spec has some extra
>>> requirements where only 8mA can be drawn max. You need to check for the
>>> otg flag. Moreover, USB3+ spec has units of 150mA meaning the device
>>> can't draw 100mA (IIRC).
>>>
>> We see issue with this patch series. For our device running at SSP, the
>> device couldn't recover from a port reset and remained in eSS.Inactive
>> state.
>>
>> This patch series is already in Greg's usb-testing. Please review and
>> help fix it.
> Should I just revert this? I'll be glad to drop it.
>
> thanks,
>
> greg k-h
Unless there's some other issue, let's not do so as it seems to be
related to my HW stability than any SW issue. Sorry for the noise.
BR,
Thinh
