On Tue, Jul 28, 2009 at 05:13:51PM +0800, Brad Lu wrote:
> This patch is to switch Qisda H21 mass storage mode to 3G modem.
> If need any modification, please tell me. Thanks.
I do need a "Signed-off-by:" line in order to be able to apply this
patch. The information about this is in the
Documentation/SubmittingPatches file. Care to add that, and resend the
patch so that it can be included?
Also, your code is wrong in a few places:
> +int usb_stor_qisda_h21_init(struct us_data *us)
> +{
> +
> + int result;
> + struct
> + {
> + unsigned char header[4];
> + unsigned char data[12];
> + } h21_Switch_Mode_Req;
Please run your patch through scripts/checkpatch.pl and fix up the
warnings it gives you.
> + h21_Switch_Mode_Req.data[5]=0x01;
You have trailing whitespace all over the place :(
> +
> + result = usb_stor_control_msg(us, us->send_ctrl_pipe,
> + 0x04,
> + USB_TYPE_STANDARD | USB_TYPE_VENDOR,
> + 0x00,
> + 0x00,
> + (void*)&h21_Switch_Mode_Req,
> + sizeof(h21_Switch_Mode_Req),
> + 1000);
You can not send a USB message off of the stack, like you did here.
Otherwise it will fail on a lot of architectures. Please dynamically
allocate it as the documentation says to do.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
