On Mon, Nov 2, 2020 at 12:12 PM Peilin Ye <yepeilin.cs@xxxxxxxxx> wrote: > > On Mon, Nov 02, 2020 at 11:10:44AM +0100, Daniel Vetter wrote: > > I'm not sure switching from int to unsigned just here makes much sense. > > All the console code is still using int con to index all the various > > arrays (I just checked fbcon.c code), and using int to index arrays is > > pretty standard. As long as we have the con < 0 check to catch evil > > userspace. > > > > There's still the switch from op to int for con_font_copy, but I think > > that's better done as part of the larger cleanup we already discussed. And > > then maybe also include patch 1 from this series in that rework. > > I see. I think at the moment there's not much we can do for > con_font_get/set/default(). _get() and _default() use *op, and _set() > uses all except one field of *op. Maybe we can change the type of *op > from console_font_op to font_desc, after cleaning up everything else? Yeah, for these one of the arguments should be the new font_desc, so that we can remove the op stuff properly. Opening up all the arguments without the font_desc doesn't make sense imo. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
