> -----Original Message----- > From: Joel Stanley <joel@xxxxxxxxx> > Sent: Friday, October 9, 2020 12:55 PM > To: Greg KH <greg@xxxxxxxxx> > Cc: Ryan Chen <ryan_chen@xxxxxxxxxxxxxx>; Andrew Jeffery > <andrew@xxxxxxxx>; Linux ARM <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>; > linux-aspeed <linux-aspeed@xxxxxxxxxxxxxxxx>; Linux Kernel Mailing List > <linux-kernel@xxxxxxxxxxxxxxx>; linux-usb@xxxxxxxxxxxxxxx; BMC-SW > <BMC-SW@xxxxxxxxxxxxxx>; Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> > Subject: Re: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig > > On Fri, 9 Oct 2020 at 04:45, Greg KH <greg@xxxxxxxxx> wrote: > > > > On Fri, Oct 09, 2020 at 10:49:35AM +0800, Ryan Chen wrote: > > > v2: > > > -Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support. > > > v1: > > > -Enable UHCI driver in aspeed_g5_defconfig. > > > > > > Signed-off-by: Ryan Chen <ryan_chen@xxxxxxxxxxxxxx> > > > > Why do you need this in a defconfig? > > I would prefer configurations that are being used to be present in the defconfig > so we can test it. I think this is a sensible change. > > Ryan, I gave you my Reviewed-by for the last version of the patch. As you did > not change the contents of this patch it is fine for you to leave my Reviewed-by > on it. Joel, thanks the review, so I need add Reviewed-by at each patch if someone have reviewed the previous patch, am I right?
