On Fri, 9 Oct 2020 at 04:45, Greg KH <greg@xxxxxxxxx> wrote: > > On Fri, Oct 09, 2020 at 10:49:35AM +0800, Ryan Chen wrote: > > v2: > > -Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support. > > v1: > > -Enable UHCI driver in aspeed_g5_defconfig. > > > > Signed-off-by: Ryan Chen <ryan_chen@xxxxxxxxxxxxxx> > > Why do you need this in a defconfig? I would prefer configurations that are being used to be present in the defconfig so we can test it. I think this is a sensible change. Ryan, I gave you my Reviewed-by for the last version of the patch. As you did not change the contents of this patch it is fine for you to leave my Reviewed-by on it. Cheers, Joel
