I have only compile tested it, but I'm pretty sure that the mutex_lock() before the return is supposed to be a mutex_unlock(). Otherwise it would be a double lock. Found by smatch (http://repo.or.cz/w/smatch.git). regards, dan carpenter Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> --- orig/drivers/media/video/ov511.c 2009-07-17 14:24:23.000000000 +0300 +++ new/drivers/media/video/ov511.c 2009-07-17 14:24:40.000000000 +0300 @@ -5878,7 +5878,7 @@ goto error; } - mutex_lock(&ov->lock); + mutex_unlock(&ov->lock); return 0; -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html