On 20-09-02 16:28:31, Roger Quadros wrote: > Peter, > > On 27/08/2020 14:14, Peter Chen wrote: > > On 20-08-25 15:00:58, Roger Quadros wrote: > > > Controller version 0x0002450D has USB2 PHY RX sensitivity issues > > > that needs to be worked around by enabling phyrst-a-enable bit > > > in PHYRST_CFG register. > > > > > > There is no way to distinguish between the controller version > > > before the device controller is started so we need to add this > > > DT property. > > > > Maybe you should say "There is no way to know controller version > > at host mode, but this workaround needs for both host and device > > mode, so we have to add this DT property", the same for the comments > > of your driver code patch. > > I will reword it to > > "There is no way to know controller version before device controller > is started and the workaround needs to be applied for both host and > device modes, so we add this DT property" > After apply it, feel free add: Reviewed-by: Peter Chen <peter.chen@xxxxxxx> Please apply above for device party commit log as well. -- Thanks, Peter Chen
