Hi,
On 9/1/20 4:32 AM, Badhri Jagan Sridharan wrote:
Hi Hans,
Kernel test robot is still reporting this issue. I have my repo synced
to ToT usb-next:
Output of git repo:
5fedf0d295d3 (origin/usb-testing, origin/usb-next) Merge 5.9-rc3 into usb-next
f75aef392f86 (tag: v5.9-rc3, origin/usb-linus, origin/main) Linux 5.9-rc3
e43327c706f2 Merge branch 'linus' of
git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
dcc5c6f013d8 Merge tag 'x86-urgent-2020-08-30' of
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
d2283cdc18d3 Merge tag 'irq-urgent-2020-08-30' of
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
0063a82de937 Merge tag 'sched-urgent-2020-08-30' of
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
Were you able to get your patch merged ?
The patch is in the review process. It looks like it needs one more
revision and then it should be on its way.
Regards,
Hans
Thanks,
Badhri
On Tue, Jul 14, 2020 at 6:55 AM Lee Jones <lee.jones@xxxxxxxxxx> wrote:
On Tue, 14 Jul 2020, Hans de Goede wrote:
Hi,
On 7/6/20 4:20 PM, Lee Jones wrote:
On Mon, 06 Jul 2020, Hans de Goede wrote:
Hi,
On 7/6/20 3:33 PM, Lee Jones wrote:
Looks as though a079973f462a3 ("usb: typec: tcpm: Remove tcpc_config
configuration mechanism") pulled out the only use of 'tcpm_altmode_ops'
last year. No need to keep it around.
Fixes the following W=1 kernel build warning(s):
drivers/usb/typec/tcpm/tcpm.c:1551:39: warning: ‘tcpm_altmode_ops’ defined but not used [-Wunused-const-variable=]
1551 | static const struct typec_altmode_ops tcpm_altmode_ops = {
| ^~~~~~~~~~~~~~~~
Cc: Guenter Roeck <linux@xxxxxxxxxxxx>
Cc: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
Cc: Hans de Goede <hdegoede@xxxxxxxxxx>
Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
This is necessary for adding Display port over Type-C support
on devices using the tcpm code, rather then firmware, to do
the Type-C alt-mode negotiation.
I have a local patch in my tree which adds support for this.
But Heikki did not like my approach, so that patch
(which needs the bits you are removing) never landed
upstream:
https://patchwork.kernel.org/patch/11199517/
Which is somewhat old now.
Yes, that's a just a little old now.
If it drags on for much longer, perhaps consider taking it out for the
time being and adding it back when you start to make use of it again?
Ok, I've just submitted a reworked patch-series upstream which
actually uses this code. So please drop this patch from your
patch-set.
No problem.
Thanks Hans.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
