Hi,
On Tue, Sep 01, 2020 at 09:01:30AM +0800, Tian Tao wrote:
> Use kobj_to_dev() instead of container_of()
OK, but can you write here why it is better? :)
> Signed-off-by: Tian Tao <tiantao6@xxxxxxxxxxxxx>
> ---
> drivers/thunderbolt/domain.c | 2 +-
> drivers/thunderbolt/switch.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thunderbolt/domain.c b/drivers/thunderbolt/domain.c
> index bba4cbf..7a192b7 100644
> --- a/drivers/thunderbolt/domain.c
> +++ b/drivers/thunderbolt/domain.c
> @@ -275,7 +275,7 @@ static struct attribute *domain_attrs[] = {
> static umode_t domain_attr_is_visible(struct kobject *kobj,
> struct attribute *attr, int n)
> {
> - struct device *dev = container_of(kobj, struct device, kobj);
> + struct device *dev = kobj_to_dev(kobj);
> struct tb *tb = container_of(dev, struct tb, dev);
>
> if (attr == &dev_attr_boot_acl.attr) {
> diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c
> index a921de9..173ce3b 100644
> --- a/drivers/thunderbolt/switch.c
> +++ b/drivers/thunderbolt/switch.c
> @@ -1649,7 +1649,7 @@ static struct attribute *switch_attrs[] = {
> static umode_t switch_attr_is_visible(struct kobject *kobj,
> struct attribute *attr, int n)
> {
> - struct device *dev = container_of(kobj, struct device, kobj);
> + struct device *dev = kobj_to_dev(kobj);
> struct tb_switch *sw = tb_to_switch(dev);
>
> if (attr == &dev_attr_device.attr) {
> --
> 2.7.4
