Re: [PATCH v2] [RFC] USB: hub.c: decrease the number of attempts of enumeration scheme

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Greg, I'm sorry for the inconvenience. I was not sure how to use
[RFC] well. If the patch works well, we already don't need to add RFC
in the subject line? This patch works fine on my target.  If it is not
needed [PFC] ,I will send the patch again without RFC in the patch
title and subject line in email later.

Best regards
Yasushi Asano


2020年8月10日(月) 16:45 Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>:
>
> On Mon, Aug 10, 2020 at 09:19:35AM +0900, Yasushi Asano wrote:
> > From: Yasushi Asano <yasano@xxxxxxxxxxxxxx>
> >
> > According to 6.7.22 A-UUT “Device No Response” for connection timeout
> > of USB OTG and EH automated compliance plan v1.2, the enumeration
> > failure has to be detected within 30 seconds. However, the old and new
> > enumeration schemes made a total of 16 attempts, and each attempt can
> > take 5 seconds to timeout, so it failed with PET test. Modify it to
> > reduce the number of attempts to 5 and pass PET test.
> >
> > in case of old_schene_first=N and use_both_schemes=Y
> > attempt 3 * new scheme, then 2 * old scheme
> > in case of old_schene_first=Y and use_both_schemes=Y
> > attempt 2 * old scheme, then 3 * new scheme
> >
> > Signed-off-by: Yasushi Asano <yasano@xxxxxxxxxxxxxx>
> > ---
> >  drivers/usb/core/hub.c | 16 +++++++---------
> >  1 file changed, 7 insertions(+), 9 deletions(-)
>
> Why is there a "[RFC]" on the subject line, do you not think this works
> properly?  Does it work for your devices and solve the problem for you?
>
> thanks,
>
> greg k-h




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux