On Sat, 2020-07-25 at 10:59 -0400, Alan Stern wrote: <snip> > > + udev = to_usb_device(dev); > > + if (usb_device_match_id(udev, new_udriver->id_table) == NULL && > > + (!new_udriver->match || new_udriver->match(udev) != 0)) > > + return 0; > > + > > + (void)!device_reprobe(dev); > > What's that '!' doing hiding in there? It doesn't affect the final > outcome, but it sure looks weird -- if people notice it at all. It's how we stop gcc from complaining about the warn_unused_result attribute on device_reprobe()... (void) is enough with clang, but not with gcc. > Aside from that, > > Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> Thanks!
