On Fri, Jul 24, 2020 at 1:32 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Fri, Jul 24, 2020 at 12:03 PM Bastien Nocera <hadess@xxxxxxxxxx> wrote:
...
> > +static int __usb_bus_reprobe_drivers(struct device *dev, void *data)
> > +{
> > + struct usb_device_driver *new_udriver = data;
> > + struct usb_device_driver *udriver;
> > + struct usb_device *udev;
> > +
> > + if (!dev->driver)
> > + return 0;
> > +
> > + udriver = to_usb_device_driver(dev->driver);
> > + if (udriver != &usb_generic_driver)
> > + return 0;
>
> What about
>
> static bool is_dev_usb_generic_driver(dev)
> {
> struct usb_device_driver *udd = dev->driver ?
> to_usb_device_driver(dev->driver) : NULL;
>
> return udd == &usb_generic_driver;
> }
>
> if (!is_dev_usb_generic_driver)
> return 0;
>
> ?
>
> > + udev = to_usb_device(dev);
> > + if (usb_device_match_id(udev, new_udriver->id_table) != NULL ||
> > + (new_udriver->match && new_udriver->match(udev) == 0))
> > + device_reprobe(dev);
> > +
> > + return 0;
>
> What about
>
> udev = to_usb_device(dev);
> if (usb_device_match_id(udev, new_udriver->id_table) == NULL)
> return 0;
> ?
>
> if (new_udriver->match && new_udriver->match(udev) == 0))
> device_reprobe(dev);
> return 0;
>
> > +}
It actually sparks a lot of similarities with
__check_usb_generic(). Perhaps you may unify them?
--
With Best Regards,
Andy Shevchenko
