Sergei Shtylyov wrote: > Hello! > > On 17.07.2020 0:58, Thinh Nguyen wrote: > >> USB 3.2 specification supports dual-lane for super-speed-plus. USB >> devices may operate at different sublink speeds. To avoid using magic >> numbers and capture the sublink speed better, introduce the >> usb_sublink_speed structure and various sublink speed attribute enum. >> >> See SSP BOS descriptor in USB 3.2 specification section 9.6.2.5 >> >> Signed-off-by: Thinh Nguyen <thinhn@xxxxxxxxxxxx> >> --- >> include/uapi/linux/usb/ch9.h | 42 >> ++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 42 insertions(+) >> >> diff --git a/include/uapi/linux/usb/ch9.h b/include/uapi/linux/usb/ch9.h >> index 2b623f36af6b..d4fd403a3664 100644 >> --- a/include/uapi/linux/usb/ch9.h >> +++ b/include/uapi/linux/usb/ch9.h >> @@ -1145,6 +1145,48 @@ enum usb_device_speed { >> USB_SPEED_SUPER_PLUS, /* usb 3.1 */ >> }; >> +/* USB 3.2 sublink speed attributes */ >> + >> +enum usb_lane_speed_exponent { >> + USB_LSE_BPS = 0, >> + USB_LSE_KBPS = 1, >> + USB_LSE_MBPS = 2, >> + USB_LSE_GBPS = 3, >> +}; >> + >> +enum usb_sublink_type { >> + USB_ST_SYMMETRIC_RX = 0, >> + USB_ST_ASYMMETRIC_RX = 1, >> + USB_ST_SYMMETRIC_TX = 2, >> + USB_ST_ASYMMETRIC_TX = 3, >> +}; >> + >> +enum usb_link_protocol { >> + USB_LP_SS = 0, >> + USB_LP_SSP = 1, >> +}; >> + >> +/** >> + * struct usb_sublink_speed - sublink speed attribute >> + * @id: sublink speed attribute ID (SSID) >> + * @mantissa: lane speed mantissa >> + * @exponent: lane speed exponent >> + * @sublink type: sublink type > > It's called just 'type' below. > Will fix. Thanks, Thinh