Re: gadget: Why do Microsoft OS descriptors need their own USB request?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Well, the history shows it was there from the very beginning, so it is
unclear (at least to me) why it was needed.

Chris

On Thu, Jul 2, 2020 at 11:00 PM Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Thu, Jul 02, 2020 at 05:11:11PM -0700, Chris Dickens wrote:
> > Hi,
> >
> > I've never understood it, so I figure I might as well just ask.  Why
> > does the Microsoft OS descriptors support require the allocation of a
> > separate USB request for the composite gadget device?  Both the
> > default control request buffer and the "special" OS descriptors buffer
> > are the same size (4KB) and use the same completion handler.  As far
> > as I can tell there is nothing distinct between them.  There's only
> > ever one outstanding USB request queued to ep0, so can the dedicated
> > USB request be removed and just share the default one?  I'm happy to
> > provide a patch, unless of course I've missed something.
>
> Try it and see, I think it was needed for some reason, but look at git
> history to be sure.
>
> thanks,
>
> greg k-h



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux