On Mon, Jun 22, 2020 at 6:11 PM Nicolas Saenz Julienne <nsaenzjulienne@xxxxxxx> wrote: > On Mon, 2020-06-22 at 17:44 +0300, Andy Shevchenko wrote: > > On Mon, Jun 22, 2020 at 5:26 PM Nicolas Saenz Julienne > > <nsaenzjulienne@xxxxxxx> wrote: > > > This reverts commit c65822fef4adc0ba40c37a47337376ce75f7a7bc. > > > > > > The initialization of Raspberry Pi 4's USB chip is now handled through a > > > reset controller. No need to directly call the firmware routine trough a > > > > trough -> through. > > > > > pci quirk. > > > > pci -> PCI. > > > > Noted > > > ... > > > > > - > > > -#include <soc/bcm2835/raspberrypi-firmware.h> > > > - > > > > Leave one blank line here. > > This being a revert, does it make sense to do so? If we are 100% strict about > it, the space should come from a separate patch. > > That said, if you insist I'll be happy to edit it. Even though, this revert depends on the previous patches, so, considered as a new patch. I leave this to the maintainer to choose the best approach (update themselves, request new version, ...). -- With Best Regards, Andy Shevchenko