Am Mittwoch, 1. Juli 2009 13:24:55 schrieb Arseniy Lartsev: > On Wednesday 01 July 2009 14:56:46 Oliver Neukum wrote: > > > + ep = (usb_pipein(acm->rx_endpoint) ? acm->dev->ep_in : > > > acm->dev->ep_out) + [usb_pipeendpoint(acm->rx_endpoint)]; > > > + if (usb_endpoint_xfer_int(&ep->desc)) > > > + usb_fill_int_urb(rcv->urb, acm->dev, > > > + acm->rx_endpoint, > > > + buf->base, > > > + acm->readsize, > > > + acm_read_bulk, rcv, 0xff); > > > > The patch is good except for this. > > We should make sure this interval matches usbcore's value. > > Would you care to redo it with that change? > > Am I right that 0xff here should be changed to ep->desc.bInterval (and to > epwrite->bInterval in the other call to usb_fill_int_urb)? Yes, exactly. Please add greg@xxxxxxxxx into CC, add a Signed-off-by line and resend. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
