Re: [PATCH 010/143] musb_host: refactor URB giveback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

David Brownell wrote:

--- a/drivers/usb/musb/musb_host.c
+++ b/drivers/usb/musb/musb_host.c
@@ -373,13 +373,13 @@ musb_giveback(struct musb_qh *qh, struct urb *urb, int
             musb_save_toggle(qh, is_in, urb);
             break;
     case USB_ENDPOINT_XFER_ISOC:
-             if (urb->error_count)
+             if (status == 0 && urb->error_count)
                     status = -EXDEV;
             break;
     }

Can you send it in a format that explains the change and it can be
applied, with proper signed-off-by and everything?

The intent would seem to be:  use the existing status,
instead of always reporting -EXDEV for ISO errors.

The resend of that one-liner can include my:

Acked-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>

... and I don't recall seeing this fixlet before, but
it's possible one of the resends didn't highlight what
was different,  so I didn't know to swap it in for the
other patches.

   It did have the following text after the tearline:

Intended to replace the patch currently in Greg's quilt tree.
Had to undo one change to musb_giveback() (now musb_advance_schedule())
that was illegetimate in the context of the current kernel...

There were a few dozen such patches,
and swapping them *all* in/out is just not gonna happen.

I've also asked you to do that simplisitic patch change yourself before recasting the patch, which was ignored as well...

- Dave

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux