Re: [Bugme-new] [Bug 13675] New: sierra_close sometimes crashes upon device removal

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 30 Jun 2009, Peter Naulls wrote:

> > The patches are already included in 2.6.31-rc1.  That's why you can't
> > apply them.  :-)
> >
> 
> Right, but then there's definitely still a problem - this bug report is against
> 2.6.31-rc1-git5.

Oho!  It turns out my patch was mangled because other concurrent 
development on the sierra driver was taking place.  This patch should 
put things right.

Alan Stern



Index: usb-2.6/drivers/usb/serial/sierra.c
===================================================================
--- usb-2.6.orig/drivers/usb/serial/sierra.c
+++ usb-2.6/drivers/usb/serial/sierra.c
@@ -814,7 +814,7 @@ static int sierra_startup(struct usb_ser
 	return 0;
 }
 
-static void sierra_disconnect(struct usb_serial *serial)
+static void sierra_release(struct usb_serial *serial)
 {
 	int i;
 	struct usb_serial_port *port;
@@ -830,7 +830,6 @@ static void sierra_disconnect(struct usb
 		if (!portdata)
 			continue;
 		kfree(portdata);
-		usb_set_serial_port_data(port, NULL);
 	}
 }
 
@@ -853,7 +852,7 @@ static struct usb_serial_driver sierra_d
 	.tiocmget          = sierra_tiocmget,
 	.tiocmset          = sierra_tiocmset,
 	.attach            = sierra_startup,
-	.disconnect        = sierra_disconnect,
+	.release           = sierra_release,
 	.read_int_callback = sierra_instat_callback,
 };
 

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux