On Mon, 29 Jun 2009, David Brownell wrote: > > Not true at all. STALL will be reported whenever: > > > > HALT is set and BABBLE isn't, and > > > > the error counter hasn't reached 0. > > > > These are the appropriate tests. > > Yes that's one appropriate case. The original code > set status to -EPIPE (stall) in exactly two spots. > > But your patch removes both of them, reporting -EPROTO > in those cases. > > So I fail to see how this is *NOT* removing all the > existing logic that reports STALL ... Apparently you skipped over the first hunk in the patch. It adds the appropriate CERR test for -EPIPE, before the MMF and DBE tests. The second hunk then removes the two existing tests. > Such explanations would go well in the > patch description ... Okay; I'll resubmit with an expanded description. > But that suggests the right fix for the problem is just to > look for that particular flavor of STALL reports *first*, > rather than remove all the existing logic to do that. That's exactly what the patch does. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
