On Wed, May 20, 2020 at 12:52:36PM +0100, Bryan O'Donoghue wrote: > So it should be "select USB_ROLE_SWITCH" not "depends on USB_ROLE_SWITCH" No. The consumers of the switches should depend on it, not silently select it. > grep -r "USB_ROLE_SWITCH" * | grep depend > drivers/usb/typec/Kconfig: depends on USB_ROLE_SWITCH > > grep -r "USB_ROLE_SWITCH" * | grep select > drivers/extcon/Kconfig: select USB_ROLE_SWITCH > drivers/usb/dwc3/Kconfig: select USB_ROLE_SWITCH > drivers/usb/cdns3/Kconfig: select USB_ROLE_SWITCH > drivers/usb/gadget/udc/Kconfig: select USB_ROLE_SWITCH > drivers/usb/mtu3/Kconfig: select USB_ROLE_SWITCH > drivers/usb/musb/Kconfig: select USB_ROLE_SWITCH > drivers/usb/musb/Kconfig: select USB_ROLE_SWITCH > drivers/usb/typec/tcpm/Kconfig: select USB_ROLE_SWITCH > drivers/usb/typec/Kconfig: select USB_ROLE_SWITCH > drivers/usb/typec/mux/Kconfig: select USB_ROLE_SWITCH > drivers/usb/common/Kconfig: select USB_ROLE_SWITCH Note that all those except tcpm supply the switch. thanks, -- heikki
