On Wed, May 20, 2020 at 11:05:26AM +0100, Bryan O'Donoghue wrote: > When I switched on USB role switching for the tps6598x I completely forgot > to add the Kconfig dependency. > > This patch ensures the dependency is there to prevent compilation error > when role-switching is off. There are stubs for the those functions, so there should not be any compilation errors. > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> > --- > drivers/usb/typec/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig > index b4f2aac7ae8a..4ea18301b15e 100644 > --- a/drivers/usb/typec/Kconfig > +++ b/drivers/usb/typec/Kconfig > @@ -64,6 +64,7 @@ config TYPEC_HD3SS3220 > config TYPEC_TPS6598X > tristate "TI TPS6598x USB Power Delivery controller driver" > depends on I2C > + depends on USB_ROLE_SWITCH How about this: depends on USB_ROLE_SWITCH || !USB_ROLE_SWITCH We then would have an option to use this driver even without that when its not needed. thanks, -- heikki
