On Fri, Jun 26, 2009 at 11:06:07AM +0200, Sascha Hauer wrote:
> On Thu, Jun 25, 2009 at 02:11:56PM +0200, Daniel Mack wrote:
> > +/* values for flags field */
> > +#define MXC_EHCI_INTERFACE_DIFF_UNI (0 << 0)
> > +#define MXC_EHCI_INTERFACE_DIFF_BI (1 << 0)
> > +#define MXC_EHCI_INTERFACE_SINGLE_UNI (2 << 0)
> > +#define MXC_EHCI_INTERFACE_SINGLE_BI (3 << 0)
> > +#define MXC_EHCI_INTERFACE_MASK (0xf)
> > +
> > +#define MXC_EHCI_POWER_PINS_ENABLED (1 << 5)
> > +#define MXC_EHCI_TTL_ENABLED (1 << 6)
>
> I just had a look into the i.MX35 datasheet. The i.MX35 has only 2 host
> cores and so the lower 16 bits of the USBCONTROL register are free for
> other uses. Freescale put bits there which the platform code probably
> wants to set. Maybe it's better to let the platform code set this
> register. How about something like
You're not specifically referring to the bit defitions you quoted, do
you? These are bits per port which should not vary for different
processor types.
>
> mx31_set_usbcontrol(unsigned int val)
> {
> clk_get() / clk_enable(),...
>
> writel();
>
> clk_put() / clk_disable()
> }
>
> which the platform can call during startup.
>
> We would get rid of the problem with different base addresses aswell.
I wasn't aware of that difference, so your approach seems fine. I hope
to find some time this week to cook something together. That will also
make the ARC/FSL code merge easier later.
Thanks,
Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
