Re: error path in usb serial if tty_port_block_til_ready fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 24 Jun 2009 23:51:40 +0100
Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:

> On Wed, 24 Jun 2009 22:24:02 +0200
> Oliver Neukum <oliver@xxxxxxxxxx> wrote:
> 
> > Hi,
> > 
> > the current error handling in serial_open does not inform the subdrivers
> > if tty_port_block_til_ready fails. This breaks the semantics the subdrivers
> > expect. The calls to open and close must be balanced.
> 
> A failing open calls the close method anyway (braindead tty layer
> prehistory). That causes a set of other bugs instead which Luca just
> posted fixes for 8(

Oops Luca sent me something else Thadeu is the person I should be
crediting.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux