On Wed, 24 Jun 2009 09:55:12 +0800 David Brownell <david-b@xxxxxxxxxxx> wrote: > On Thursday 11 June 2009, Alek Du wrote: > > + { > > + /* handle MRST USB 2.0 EHCI controller */ > > + PCI_DEVICE_CLASS(0x0c2000, ~0), > > + .driver_data = (unsigned long) &ehci_pci_hc_driver, > > + }, > > + { > > + PCI_DEVICE_CLASS(0x0c03fe, ~0), > > + .driver_data = (unsigned long) &ehci_pci_hc_driver, > > + }, > > If those are really class identifiers then surely they > ought to be declared symbolically in the same system > header as the other PCI classes. We may have a whole PCI ID patch for Intel Moorestown Platform later. But before that, can I still use them here as this? The class id is only used here. I will send update patch once the PCI part patch in mainline. I just do not want this depends on the PCI part. > And please explain acronyms like MRST and MPH, which > seem unique to Intel's stuff. MRST = Intel Moorestown Platform which is a LPIA (Low power IA) platform MPH = Multi-port Host, this host has integrated port controller logic for multiple host ports (1~6 downstream port(s)). Also it supports LPM (Link Power Management). Thanks, Alek -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html