On Wed, 24 Jun 2009 09:26:44 +0800 David Brownell <david-b@xxxxxxxxxxx> wrote: > On Wednesday 10 June 2009, Alek Du wrote: > > From 5a1db37084a2e0de9bdc645cd7cf9a3d364855da Mon Sep 17 00:00:00 2001 > > From: Alek Du <alek.du@xxxxxxxxx> > > Date: Wed, 10 Jun 2009 12:29:57 +0800 > > Subject: [PATCH] EHCI: Add no_io_watchdog feature to ehci_hcd > > > > The IO watchdog wakes up system too much (as defined as EHCI_IO_JIFFIES, ~10 > > times per second) and actually it won't benefit most no interrupt quirk EHCI > > controllers. Most good EHCI controllers needn't IO watchdog at all. > > Right. It happened because VIA controllers had some issues. > A few other early controllers would trigger it now and then, > but I think that was because of now-fixed bugs. > > What would be most useful is to turn this flag on for > all non-VIA controllers. Or maybe ... just turn it into a > "needs_io_watchdog" quirk, which is enabled for VIA and > any other controllers that need it. > > > > This patch > > will let them have a chance to disable it. The Intel Moorestown EHCI controller > > patch will leverage it later. > > > > Signed-off-by: Alek Du <alek.du@xxxxxxxxx> > > Acked-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx> > > ... though I'd prefer to see the sense of this inverted, > and have the flag enabled only for VIA. That'd be a bit > riskier though. > > David, Yes, I won't break any other EHCI HCDs. Let's have the flag first, and then turn on no_io_watchdog for various HCDs one by one. And maybe later someone would commit a inverted logical patch :-) Thanks, Alek -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
