Re: [PATCH v3] [resend] EHCI: split ehci_qh structure into hw and sw parts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 22 Jun 2009, Alek Du wrote:

> From 7dc04f6d1feaa10f8e9c8d8edd4714f7dae8e92f Mon Sep 17 00:00:00 2001
> From: Alek Du <alek.du@xxxxxxxxx>
> Date: Thu, 18 Jun 2009 16:52:48 +0800
> Subject: [PATCH] EHCI: split ehci_qh structure into hw and sw parts
> 
> The ehci_qh structure merged hw and sw together which is not good:
> 1. More and more items are being added into ehci_qh, the ehci_qh software
>    part are unnecessary to be allocated in DMA qh_pool.
> 2. If HCD has local SRAM, the sw part will consume it too, and it won't
>    bring any benefit.
> 3. For non-x86 system, the entire ehci_qh is uncachable, actually we
>    only need the hw part to be uncacheable. Split them will give the sw
>    part cacheable feature.
> 
> Signed-off-by: Alek Du <alek.du@xxxxxxxxx>

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

I have not gone over this to verify every little detail, but in general 
it looks sane.  However this is a significant change to the driver, so 
David really should approve it before it is merged.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux