On Wed, Jan 29, 2020 at 03:47:29PM +0000, Richard Dodd wrote: > On Mon, Jan 13, 2020 at 9:40 AM Oliver Neukum <oneukum@xxxxxxxx> wrote: > > > > Am Sonntag, den 12.01.2020, 12:06 +0000 schrieb Richard Dodd: > > > Hello > > > > > > I've got a Novation midi-over-usb device (LaunchControl XL) that works > > > correctly on boot, but remains in power-off mode when waking from > > > sleep. > > > > > > I suspect that there is some sort of initialisation that needs to be > > > applied. Could anyone suggest possible causes, or point me in the > > > direction of the relevant source code. I found `sound/usb/quirks.c`, > > > which seems to be the place to handle this kind of thing, but there is > > > no mention of my device anywhere in the source tree at present > > > (1235:0061). > > > > Hi, > > > > some devices need an additional reset. They have the quirk RESET_RESUME > > in that file. Try adding your device to that list and recompile your > > kernel. > > > > HTH > > Oliver > > > > Hi > > I found the list you are talking about in `drivers/usb/core/quirks.c`, > and when I patched it, my device correctly woke up after suspend. :) > > Can I upstream the patch by posting it here. The patch is attached to > this email. Can you please resend this in the format described in the documentation so that we can apply it to the tree? thanks, greg k-h
