On Mon, Jan 06, 2020 at 04:10:05PM +0100, Linus Walleij wrote:
> Instead of using the legacy GPIO API and keeping track on
> polarity inversion semantics in the driver, switch to use
> GPIO descriptors for this driver and change all consumers
> in the process.
>
> This makes it possible to retire platform data completely:
> the only remaining platform data member was "wakeup" which
> was intended to make the vbus interrupt wakeup capable,
> but was not set by any users and thus remained unused. VBUS
> was not waking any devices up. Leave a comment about it so
> later developers using the platform can consider setting it
> to always enabled so plugging in USB wakes up the platform.
>
> Cc: Robert Jarzmik <robert.jarzmik@xxxxxxx>
> Cc: Daniel Mack <daniel@xxxxxxxxxx>
> Cc: Haojian Zhuang <haojian.zhuang@xxxxxxxxx>
> Acked-by: Felipe Balbi <balbi@xxxxxxxxxx>
> Acked-by: Sylwester Nawrocki <snawrocki@xxxxxxxxxx>
> Acked-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Acked-by: Robert Jarzmik <robert.jarzmik@xxxxxxx>
> ---
> ChangeLog v1->v2:
> - Fix a chip label typo in mach-s3c64xx
> - Collect the ACKs!
With this applied, I now get the following build warnings:
drivers/usb/phy/phy-gpio-vbus-usb.c: In function ‘gpio_vbus_probe’:
drivers/usb/phy/phy-gpio-vbus-usb.c:237:11: warning: unused variable ‘gpio’ [-Wunused-variable]
237 | int err, gpio, irq;
| ^~~~
drivers/usb/phy/phy-gpio-vbus-usb.c:235:20: warning: unused variable ‘gpiod’ [-Wunused-variable]
235 | struct gpio_desc *gpiod;
| ^~~~~
Can you please fix that up and resend?
thanks,
greg k-h
