Linus Walleij <linus.walleij@xxxxxxxxxx> writes: > On Sun, Jan 12, 2020 at 12:54 PM Robert Jarzmik <robert.jarzmik@xxxxxxx> wrote: > There are two names. The lookup name that I just invented to be > "vbus" and "pullup". One reason to choose these names is that > if someone migrates the platforms to device tree they can name > the DT property vbus-gpios = <...>; pullup-gpios = <...>; > which I think makes sense. > > Then there is the consumer name that is shown in debugfs etc. > > That is preserved with these calls: > > + gpiod_set_consumer_name(gpio_vbus->vbus_gpiod, "vbus_detect"); > (...) > + if (gpio_vbus->pullup_gpiod) > + gpiod_set_consumer_name(gpio_vbus->pullup_gpiod, "udc_pullup"); Ah yes, I see it now. For the mach-pxa part : Acked-by: Robert Jarzmik <robert.jarzmik@xxxxxxx> Cheers. -- Robert