Hi Hanjie, On Fri, Jan 10, 2020 at 6:43 AM Hanjie Lin <hanjie.lin@xxxxxxxxxxx> wrote: > > Add the Amlogic A1 Family USB2 PHY Bindings > > It supports Host mode only. > > Signed-off-by: Hanjie Lin <hanjie.lin@xxxxxxxxxxx> > Signed-off-by: Yue Wang <yue.wang@xxxxxxxxxxx> > --- > .../bindings/phy/amlogic,meson-a1-usb2-phy.yaml | 62 ++++++++++++++++++++++ > 1 file changed, 62 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml there are only two differences to the existing amlogic,meson-g12a-usb2-phy.yaml binding: - different compatible string (the existing binding already has an enum, so that would be easy to extend) - new, mandatory power-domains property (Documentation/devicetree/bindings/sound/allwinner,sun4i-a10-codec.yaml has examples how to make properties mandatory based on the compatible string) have you considered merging this with the existing amlogic,meson-g12a-usb2-phy.yaml binding? this is not a "must have" in my opinion, I still want to hear your opinion on this topic! Martin
