Hi Hanjie, On Fri, Jan 10, 2020 at 6:43 AM Hanjie Lin <hanjie.lin@xxxxxxxxxxx> wrote: [...] > @@ -37,6 +43,11 @@ properties: > > clocks: > minItems: 1 > + maxItems: 4 the driver parses one clock for G12A/G12B/SM1 and three clocks for A1 if there is a fourth clock: do we need to manage it in the driver? (note: dt-bindings always represent the hardware, so if there's a fourth clock which the driver doesn't need then it's perfectly valid to describe it here. a comment which clock this is helps in the code-review process) > + clock-names: > + minItems: 1 > + maxItems: 4 I let Rob comment on this, personally I prefer naming the clocks explicitly also I think clock-names has to be a mandatory property for A1 (see Documentation/devicetree/bindings/sound/allwinner,sun4i-a10-codec.yaml for an example which makes properties mandatory depending on the compatible string) Martin
