On Thu, Jan 9, 2020 at 10:07 AM Felipe Balbi <balbi@xxxxxxxxxx> wrote: > > > Hi, > > Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> writes: > > > Hi All, > > > > On 15.12.2019 17:41, Hans de Goede wrote: > >> Hi, > >> > >> On 13-12-2019 18:46, Dmitry Torokhov wrote: > >>> We should not be reaching into property entries and initialize them by > >>> hand, but rather use proper initializer macros. This way we can alter > >>> internal representation of property entries with no visible changes to > >>> their users. > >>> > >>> Reported-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> > >>> Tested-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> > >>> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > >>> --- > >>> > >>> It would be good if this could go through Rafael's tree as it is needed > >>> for the rest of my software_node/property_entry rework patch series > >>> which I would love not to delay till 5.6. > >> > >> Patch looks good to me: > >> > >> Acked-by: Hans de Goede <hdegoede@xxxxxxxxxx> > > > > This patch is instantly needed as the issue it fixes is again triggered > > in current (20200107) linux-next by commit e6bff4665c59 "software node: > > replace is_array with is_inline". > > > > Felipe: could You ack it, so it could be merged via Rafael's tree > > together with related device property changes? > > Here you go: > > Acked-by: Felipe Balbi <balbi@xxxxxxxxxx> Thanks, applied.