Re: [PATCH v2 3/9] thunderbolt: Populate PG field in hot plug acknowledgment packet

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 17, 2019 at 04:56:32PM +0200, Mika Westerberg wrote:
> On Tue, Dec 17, 2019 at 01:47:45PM +0100, Greg Kroah-Hartman wrote:
> > On Tue, Dec 17, 2019 at 03:33:39PM +0300, Mika Westerberg wrote:
> > > USB4 1.0 section 6.4.2.7 specifies a new field (PG) in notification
> > > packet that is sent as response of hot plug/unplug events. This field
> > > tells whether the acknowledgment is for plug or unplug event. This needs
> > > to be set accordingly in order the router to send further hot plug
> > > notifications.
> > > 
> > > To make it simpler we fill the field unconditionally. Legacy devices do
> > > not look at this field so there should be no problems with them.
> > > 
> > > While there rename tb_cfg_error() to tb_cfg_ack_plug() and update the
> > > log message accordingly. The function is only used to ack plug/unplug
> > > events.
> > > 
> > > Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> > 
> > First 3 patches look "trivial" enough for me to take right now, any
> > objection to that?
> 
> No objections from my side :)
> 
> > Should I be using my usb tree for this?
> 
> Yes, I think it makes sense now that this is also under USB IF umbrella.

Ok, now done, thanks.

greg k-h



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux