On Fri, Jun 12, 2009 at 12:06:13AM +0800, Alek Du wrote:
> On Thu, 11 Jun 2009 23:18:54 +0800
> Greg KH <greg@xxxxxxxxx> wrote:
>
> > On Thu, Jun 11, 2009 at 10:50:21PM +0800, Alek Du wrote:
> > > Changes from v1:
> > >
> > >
> > > +#ifdef CONFIG_USB_LANGWELL_OTG
> > > +#include <linux/usb/otg.h>
> > > +#include <linux/usb/langwell_otg.h>
> > > +#endif
> >
> > Don't use ifdefs in .c code, just always include the header files
> > please.
> >
> > > /*-------------------------------------------------------------------------*/
> > >
> > > /*
> > > @@ -1046,6 +1051,9 @@ MODULE_LICENSE ("GPL");
> > > #ifdef CONFIG_PCI
> > > #include "ehci-pci.c"
> > > #define PCI_DRIVER ehci_pci_driver
> > > +#ifdef CONFIG_USB_LANGWELL_OTG
> > > +#define LNW_OTG_HOST_DRIVER ehci_otg_driver
> > > +#endif
> >
> > Why is this ifdef and define needed?
> >
>
> Greg, if you look into the original source file, you will find all the
> other drivers are hooked into ehci-hcd.c like this ... If I use a new
> way ... will let this driver look different ...
Ah, you are correct, sorry for the noise.
What a messy file :)
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
