Re: [PATCH 4/4] EHCI: Support Intel Moorestown EHCI controller SRAM as DMA pool caching

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 11 Jun 2009 23:14:56 +0800
Greg KH <greg@xxxxxxxxx> wrote:

> >  drivers/usb/core/buffer.c   |    5 +++++
> >  drivers/usb/core/hcd.h      |    1 +
> >  drivers/usb/host/ehci-hcd.c |    9 ++++++++-

> > +static unsigned int sram_force_off;
> > +module_param(sram_force_off, int, S_IRUGO);
> > +MODULE_PARM_DESC(sram_force_off,
> > +		"force private SRAM off, otherwise SRAM will be used"
> > +		"if detected\n");
> 
> Ick, no.  Can't you detect this in the hardware and do it dynamically?
> We don't need any more configuration options.  Especially something as
> vague and undocumented as this.
>

hmmm... This is only for testing/debug usage, actually I can remove it. Thanks.

 
> So no, please don't do this.
> 
> thanks,
> 
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux