> -----Original Message----- > From: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> > Sent: Tuesday, October 1, 2019 8:48 AM > To: Limonciello, Mario > Cc: gregkh@xxxxxxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; > andreas.noever@xxxxxxxxx; michael.jamet@xxxxxxxxx; YehezkelShB@xxxxxxxxx; > rajmohan.mani@xxxxxxxxx; nicholas.johnson-opensource@xxxxxxxxxxxxxx; > lukas@xxxxxxxxx; stern@xxxxxxxxxxxxxxxxxxx; anthony.wong@xxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [RFC PATCH 01/22] thunderbolt: Introduce tb_switch_is_icm() > > > [EXTERNAL EMAIL] > > On Tue, Oct 01, 2019 at 01:36:49PM +0000, Mario.Limonciello@xxxxxxxx wrote: > > > -----Original Message----- > > > From: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> > > > Sent: Tuesday, October 1, 2019 7:47 AM > > > To: Greg Kroah-Hartman > > > Cc: linux-usb@xxxxxxxxxxxxxxx; Andreas Noever; Michael Jamet; Yehezkel > Bernat; > > > Rajmohan Mani; Nicholas Johnson; Lukas Wunner; Alan Stern; Limonciello, > Mario; > > > Anthony Wong; linux-kernel@xxxxxxxxxxxxxxx > > > Subject: Re: [RFC PATCH 01/22] thunderbolt: Introduce tb_switch_is_icm() > > > > > > > > > [EXTERNAL EMAIL] > > > > > > On Tue, Oct 01, 2019 at 02:10:05PM +0200, Greg Kroah-Hartman wrote: > > > > On Tue, Oct 01, 2019 at 02:38:09PM +0300, Mika Westerberg wrote: > > > > > We currently differentiate between SW CM and ICM by looking directly at > > > > > > > > You should spell out what "SW CM" and "ICM" means please :) > > > > > > Indeed, sorry about that. I will spell them out in next version. > > > > > > SW CM is Software Connection manager, essentially > > > drivers/thunderbolt/tb.c. > > > > In some of the documentation I've seen non-internal connection manager > referred to > > as ECM, which I guess is an external connection manager? To be consistent with > various > > documentations maybe that would be better than "SW CM". > > That's the first time I hear about ECM ;-) > > Here at Intel we use term "SW CM" and "FW CM" and IMHO they are better > than ECM/ICM. But if people insist I can change them. I do agree with you, SW CM and FW CM are clearer than ECM/ICM, maybe just reference both in the comments so if someone is aware of ECM/ICM from some documents they can relate the two concepts.
