On Tue, 2009-06-02 at 13:34 -0700, Greg KH wrote: > On Mon, Jun 01, 2009 at 11:03:47AM -0700, Elina Pasheva wrote: > > Subject: [PATCH 005/008] [RESUBMIT2] USB: serial: sierra_close() modifications > > From: Elina Pasheva <epasheva@xxxxxxxxxxxxxxxxxx> > > > > The following is summary of changes we have made to sierra.c driver in > > [PATCH 005/008] from the series dealing with improving urb handling: > > - Moved sierra_close() before sierra_open() to resolve dependencies introduced > > by the code reorganization. > > - Modified sierra_close() to call sierra_stop_rx_urbs() and sierra_release_urb() > > functions added in previous patch. > > Signed-off-by: Elina Pasheva <epasheva@xxxxxxxxxxxxxxxxxx> > > This patch does not apply at all (after applying the first 4 in this > series. > > This is the hunk that fails: > > > @@ -769,23 +797,6 @@ static void sierra_dtr_rts(struct usb_se > > } > > } > > > > -static void sierra_close(struct usb_serial_port *port) > > sierra_close() has a different type... > > The first 4 patches in this series are a bit strange, you are just > adding new functions, but not calling them. Now we have new compiler > warnings added to the build :( Hi Greg, The new functions added to sierra driver with the 4 patches you applied will be called by the modified code in the subsequent patches. My goal was to submit the independent changes first and then add the dependencies (i.e. the calls to these functions). I am sorry if I have confused you. > > I'll leave these 4 in the tree, but care to respin everything else after > this and resend them to me? Thank you very much for applying the patches. I will indeed have to respin everything else and send it to you. We noticed that there were changes in linux-next tree affecting sierra driver e.g. tty is no longer a parameter in the prototypes, etc. This is what I am planning to do: --re-sync with linux-next which was re-generated today (June 2, 2009) --apply greg-patches to linux-next and use the resulting sierra.c as base for generating the rest of the patches. --re-submit the rest of the patches as soon as possible. Please let me know if this would work for you? Regards, Elina -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
