On Mon, Jun 01, 2009 at 11:03:47AM -0700, Elina Pasheva wrote: > Subject: [PATCH 005/008] [RESUBMIT2] USB: serial: sierra_close() modifications > From: Elina Pasheva <epasheva@xxxxxxxxxxxxxxxxxx> > > The following is summary of changes we have made to sierra.c driver in > [PATCH 005/008] from the series dealing with improving urb handling: > - Moved sierra_close() before sierra_open() to resolve dependencies introduced > by the code reorganization. > - Modified sierra_close() to call sierra_stop_rx_urbs() and sierra_release_urb() > functions added in previous patch. > Signed-off-by: Elina Pasheva <epasheva@xxxxxxxxxxxxxxxxxx> This patch does not apply at all (after applying the first 4 in this series. This is the hunk that fails: > @@ -769,23 +797,6 @@ static void sierra_dtr_rts(struct usb_se > } > } > > -static void sierra_close(struct usb_serial_port *port) sierra_close() has a different type... The first 4 patches in this series are a bit strange, you are just adding new functions, but not calling them. Now we have new compiler warnings added to the build :( I'll leave these 4 in the tree, but care to respin everything else after this and resend them to me? confused, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
