Re: [ptp-gadget][[PATCH 2/2] Use LDFLAGS in link step

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 29 May 2009, Koen Kooi wrote:

> Signed-off-by: Koen Kooi <koen@xxxxxxxxxxxxxxxxxxxxx>
> ---
>  Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index d56d320..42f6003 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1,7 +1,7 @@
>  CPPFLAGS	:= -Wall -I$(KERNEL_SRC)/include
>  
>  ptp:		ptp.o usbstring.o
> -	$(CROSS_COMPILE)gcc -lpthread -o $@ $^
> +	$(CROSS_COMPILE)gcc -lpthread ${LDFLAGS} -o $@ $^
>  
>  ptp.o:		ptp.c usbstring.h
>  	$(CROSS_COMPILE)gcc $(CPPFLAGS) -c -o $@ $<

Not sure we want this one. First, you'd have to use $() instead of ${} 
just for consistency. Secondly, what ld flags were missing there?

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office@xxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux