Re: [PATCH 3/4] USB: iuu_phoenix: minimual version of set_termios.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On Wed, May 27, 2009 at 12:01:34AM +0200, Oliver Neukum wrote:
> Am Dienstag, 26. Mai 2009 23:30:15 schrieb Olivier Bornet:
> > +static void iuu_set_termios(struct tty_struct *tty,
> > +               struct usb_serial_port *port, struct ktermios *old_termios)
> > +{
> 
> [..]
> > +       /* set it */
> > +       status = iuu_uart_baud(port,
> > +                       (clockmode == 2) ? 16457 : 9600 * boost / 100,
> > +                       &actual, parity);
> 
> So what do you do with the status?

Humm... Good question. I don't now if we can do something interesting with it
in iuu_set_termios(). Maybe return the old_termios is we has problems, instead
of returning the new one ? or just call iuu_uart_baud() without storing the
status.

BTW, I see now that the return code of iuu_uart_baud() is never used in the
code. :-(

Have a nice day.

        Olivier
-- 
Olivier Bornet
Olivier.Bornet@xxxxxxx
Swiss Ice Hockey Results : http://puck.ch/
Get my PGP-key at http://puck.ch/pgp or at http://pgp.mit.edu/

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux