On Tue, 2009-05-26 at 10:06 -0400, Alan Stern wrote: > On Tue, 26 May 2009, Benjamin Herrenschmidt wrote: > > > Well, both our patches are bogus in the sense that they will leak > > the stuff in the port structure. > > That's not true at all. Take a look at the destroy_serial() routine. Right... hrm. This is an horrible mess, I can't wait to see that refcount going wrong and things trying to double free or leaking the structure. Oh well, fix it the way your want, I don't care as long as it's fixed. This driver is just plain horrible. Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html