RE: [PATCH v7 3/7] usb: typec: driver for TI HD3SS3220 USB Type-C DRP port controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg,

Thanks for the feedback.

> -----Original Message-----
> From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Sent: Tuesday, June 18, 2019 7:48 AM
> To: Biju Das <biju.das@xxxxxxxxxxxxxx>
> Cc: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>; Matthias Brugger
> <matthias.bgg@xxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Felipe Balbi
> <balbi@xxxxxxxxxx>; Chunfeng Yun <chunfeng.yun@xxxxxxxxxxxx>; linux-
> usb@xxxxxxxxxxxxxxx; Simon Horman <horms@xxxxxxxxxxxx>; Yoshihiro
> Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>; Geert Uytterhoeven
> <geert+renesas@xxxxxxxxx>; Chris Paterson
> <Chris.Paterson2@xxxxxxxxxxx>; Fabrizio Castro
> <fabrizio.castro@xxxxxxxxxxxxxx>; linux-renesas-soc@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v7 3/7] usb: typec: driver for TI HD3SS3220 USB Type-C
> DRP port controller
> 
> On Fri, May 31, 2019 at 10:59:56AM +0100, Biju Das wrote:
> > Driver for TI HD3SS3220 USB Type-C DRP port controller.
> >
> > The driver currently registers the port and supports data role swapping.
> >
> > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx>
> > Acked-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> > ---
> 
> I tried to apply this, but get the following build error:
> 
> drivers/usb/typec/hd3ss3220.c: In function hd3ss3220_probe:
> drivers/usb/typec/hd3ss3220.c:179:23: error: implicit declaration of function
> fwnode_usb_role_switch_get; did you mean usb_role_switch_get? [-
> Werror=implicit-function-declaration]
>   hd3ss3220->role_sw = fwnode_usb_role_switch_get(connector);
>                        ^~~~~~~~~~~~~~~~~~~~~~~~~~
>                        usb_role_switch_get
> drivers/usb/typec/hd3ss3220.c:179:21: warning: assignment to struct
> usb_role_switch * from int makes pointer from integer without a cast [-Wint-
> conversion]
>   hd3ss3220->role_sw = fwnode_usb_role_switch_get(connector);
>                      ^
> 
> You might want to fix that so the series can be applied :(

This patch depend upon the  below commit[1] which introduced the new API "fwnode_usb_role_switch_get()"

[1] https://patchwork.kernel.org/patch/10986227/ ("usb: roles: Add fwnode_usb_role_switch_get() function")

Patch  [1] depend up on [2] ,[3] and  the binding patch [4]

[2] https://patchwork.kernel.org/patch/10986233/  ( "device connection: Add fwnode_connection_find_match()")
[3] https://patchwork.kernel.org/patch/10986221/  ("usb: roles: Introduce stubs for the exiting functions in role.h")

Binding patch
[4] https://patchwork.kernel.org/patch/10986215/ ("dt-binding: usb: add usb-role-switch property")

Regards,
Biju







[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux