Hi Christoph, > From: Christoph Hellwig, Sent: Thursday, June 13, 2019 5:51 PM > > On Thu, Jun 13, 2019 at 08:46:00AM +0000, Yoshihiro Shimoda wrote: > > I believe this patch I sent has already covered it. What do you think? > > > > For examples (all value units are "sectors"): > > default mapping size max_sectors > > case 1 240 MAX 2048 --> we use 2048 > > case 2 240 512 2048 --> we use 512 > > case 3 240 128 2048 --> we use 128 > > case 4 240 128 64 --> we use 64 > > Yes, I guess your version is fine after all: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thank you for your review! > although I think it might be simpler to just read the value back > from the queue in the end. Ah, now I understand why you suggest it. I agree with you. This patch changed 23 lines. But, it will change a few lines only. So, I'll make such a patch. Best regards, Yoshihiro Shimoda
