Hi Jonas, On Thu, Jun 13, 2019 at 11:34:33AM +0200, Jonas Stenvall wrote: > Fixed a coding style issue, replacing unsigned with unsigned int. No concerns on my side. FWIW, the 'bare use of unsigned' coding style inconsistency is quite common in the USB gadget framework [1-2]. Depending on the feedback from the maintainers, I see below potential outcomes for this patch (sorted by my personal estimation of chance): - we take it and we fix the rest on best-effort basis. - we kindly ask you to fix the issue globally in USB gadget space. - we don't care, as this is not a functional issue. We rather prefer to concentrate on functional problems. Deciding on the above is a matter of maintainer's preference. > > Signed-off-by: Jonas Stenvall <jonas.stenvall.umea@xxxxxxxxx> > --- > drivers/usb/gadget/function/u_audio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >From my end: Reviewed-by: Eugeniu Rosca <erosca@xxxxxxxxxxxxxx> [1] git grep -E "unsigned [^(int|short|char|long)]" -- drivers/usb/gadget/function | wc -l 32 [2] git grep -E "unsigned [^(int|short|char|long)]" -- drivers/usb/gadget | wc -l 99 -- Best Regards, Eugeniu.
