Finally I can name the first bad commit: git bisect good ad74b8649beaf1a22cf8641324e3321fa0269d16 is the first bad commit commit ad74b8649beaf1a22cf8641324e3321fa0269d16 Author: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> Date: Tue Apr 23 17:21:48 2019 +0300 usb: typec: ucsi: Preliminary support for alternate modes With UCSI the alternate modes, just like everything else related to USB Type-C connectors, are handled in firmware. The operating system can see the status and is allowed to request certain things, for example entering and exiting the modes, but the support for alternate modes is very limited in UCSI. The feature is also optional, which means that even when the platform supports alternate modes, the operating system may not be even made aware of them. UCSI does not support direct VDM reading or writing. Instead, alternate modes can be entered and exited using a single custom command which takes also an optional SVID specific configuration value as parameter. That means every supported alternate mode has to be handled separately in UCSI driver. This commit does not include support for any specific alternate mode. The discovered alternate modes are now registered, but binding a driver to an alternate mode will not be possible until support for that alternate mode is added to the UCSI driver. Tested-by: Ajay Gupta <ajayg@xxxxxxxxxx> Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> :040000 040000 f19a610d131d6d3e6397934562dd6112e78b2415 76df0e463eeacf57157adba0291fc9577c7d5145 M dr ivers git bisect log git bisect start # bad: [132d68d37d33f1d0b9c1f507c8b4d64c27ecec8a] Merge tag 'usb-5.2-rc1' of git://git.kernel.org/pub/scm/ linux/kernel/git/gregkh/usb git bisect bad 132d68d37d33f1d0b9c1f507c8b4d64c27ecec8a # good: [86dc59e39031fb0d366d5b1f92db015b24bef70b] net: dsa: sja1105: Make 'sja1105et_regs' and 'sja1105pq rs_regs' static git bisect good 86dc59e39031fb0d366d5b1f92db015b24bef70b # good: [80f232121b69cc69a31ccb2b38c1665d770b0710] Merge git://git.kernel.org/pub/scm/linux/kernel/git/dav em/net-next git bisect good 80f232121b69cc69a31ccb2b38c1665d770b0710 # good: [5d438e200215f61ca6a7aa69f3c4e035ac54d8ee] usb: typec: ucsi: ccg: add get_fw_info function git bisect good 5d438e200215f61ca6a7aa69f3c4e035ac54d8ee # bad: [6f6a407a591ebe3e4c6bd2329b29862b3980a3ca] Merge tag 'usb-serial-5.2-rc1' of https://git.kernel.org /pub/scm/linux/kernel/git/johan/usb-serial into usb-next git bisect bad 6f6a407a591ebe3e4c6bd2329b29862b3980a3ca # bad: [e823d948b7e53dc982c867ac4ce7877fc0418897] usb: musb: dsps: Use dev_get_drvdata() git bisect bad e823d948b7e53dc982c867ac4ce7877fc0418897 # bad: [6fee3787ea7aebf25fecdce325ee9b2150c5727b] dt-bindings: usb-xhci: Add r8a774c0 support git bisect bad 6fee3787ea7aebf25fecdce325ee9b2150c5727b # bad: [cf28369c634fafb5f4e81750cba6988cdb4b4490] usb: typec: Add driver for NVIDIA Alt Modes git bisect bad cf28369c634fafb5f4e81750cba6988cdb4b4490 # bad: [ad74b8649beaf1a22cf8641324e3321fa0269d16] usb: typec: ucsi: Preliminary support for alternate mode s git bisect bad ad74b8649beaf1a22cf8641324e3321fa0269d16 # good: [5c9ae5a87573d38cfc4c740aafda2fa6ce06e401] usb: typec: ucsi: ccg: add firmware flashing support git bisect good 5c9ae5a87573d38cfc4c740aafda2fa6ce06e401 # first bad commit: [ad74b8649beaf1a22cf8641324e3321fa0269d16] usb: typec: ucsi: Preliminary support for a lternate modes Best regards, Vladimir чт, 6 июн. 2019 г. в 02:59, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>: > > On Wed, Jun 05, 2019 at 04:36:23PM +1000, Vladimir Yerilov wrote: > > Good day Mr. Kroah-Hartman, > > > > I've found the culprit commit. It took a while though but now I'm sure: > > > > commit - brief decription - time - works (y) or not (n) > > 670784fb4ebe54434e263837390e358405031d9e - rc1 2019-05-20 > > e260ad01f0aa9e96b5386d5cd7184afd949dc457 - rc0 2019-05-14 19:52:51 -0700 n > > 8ea5b2abd07e2280a332bd9c1a7f4dd15b9b6c13 - rc0 2019-05-09 19:35:41 -0700 n > > 54516da1ea859dd4f56ebba2e483d2df9d7c8a32 - rc0 2019-05-05 21:58:36 -0700 y > > 71ae5fc87c34ecbdca293c2a5c563d6be2576558 - rc0 2019-05-06 20:29:45 -0700 y > > 80f232121b69cc69a31ccb2b38c1665d770b0710 - rc0 2019-05-07 22:03:58 -0700 y > > a2d635decbfa9c1e4ae15cb05b68b2559f7f827c - rc0 2019-05-08 21:35:19 -0700 n > > 132d68d37d33f1d0b9c1f507c8b4d64c27ecec8a - rc0 2019-05-08 10:03:52 -0700 n > > 86dc59e39031fb0d366d5b1f92db015b24bef70b - rc0 2019-05-08 09:46:44 -0700 y > > > > So 86dc59e39031fb0d366d5b1f92db015b24bef70b is the last working for > > me, and 132d68d37d33f1d0b9c1f507c8b4d64c27ecec8a is the breaking one: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.2-rc3&id=132d68d37d33f1d0b9c1f507c8b4d64c27ecec8a > > 132d68d37d33 ("Merge tag 'usb-5.2-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb") > is a merge point, which is odd, you should be able to drop down into > that and find the exact wrong commit. > > what does 'git bisect log' show? > > thanks, > > greg k-h -- ---- Best regards, Vladimir Yerilov
