Re: [Bug 13354] Entry in "unusual_devs" keeps modem device from switching

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, all,

I have a little patch ready (against 2.6.30-rc6) but am unsure if I should post it here "officially". Frankly, this is my first, and I don't know about the exact DOs and DONTs.

So I rather include just a link here:
http://www.draisberghof.de/files/option_ms.diff

What it does:
- fixes the bug Alan Stern pointed at (reading the response after
  switching)
- introduces an additional test for the vendor information included
  in the INQUIRY data (ASCII); if it's not "Option", leave the
  device alone. If it is, proceed according to the "option_zero_cd"
  parameter

Tested with Option GlobeSurfer Icon and my cell phone (Samsung SGH_U900) which has the same ID when in storage mode.

Bulk send/receive errors during the inquiry process are not exposed, instead the result is the same as with any "non-Option" device: do nothing. Is that OK?

One thing I noticed: the switching function does not read the CSW after the transfers. This might be a reason for quirks with "non-Option" devices if the procedure is applied to them.


Josua Dietze
--
Man is the only creature on earth enabled to take a
warm meal while flying!                      Loriot
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux